New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed regression with specifying arg names in call syntax #2480

Merged

tkyc merged 8 commits into main from call-escape-syntax-fix

Jul 23, 2024

Member

tkyc commented Jul 22, 2024

Fixes #2477


          Fixed regression with specifying arg names in call syntax

b2991f9

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java Fixed Show resolved Hide resolved

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java Fixed Show resolved Hide resolved

codecov bot commented Jul 22, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.81%. Comparing base (aef7c5d) to head (c252a8b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2480      +/-   ##
============================================
+ Coverage     50.76%   50.81%   +0.05%     
- Complexity     3886     3902      +16     
============================================
  Files           145      145              
  Lines         33481    33481              
  Branches       5690     5690              
============================================
+ Hits          16998    17015      +17     
- Misses        14043    14046       +3     
+ Partials       2440     2420      -20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


          Corrected inefficient regex

8145e04

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java Fixed Show fixed Hide fixed

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java Fixed Show fixed Hide fixed


          Corrected inefficient regex

3798a83

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java Fixed Show fixed Hide fixed


          Corrected inefficient regex p2

fb69c03

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java Fixed Show fixed Hide fixed


          Corrected inefficient regex p3

771a0b1

github-advanced-security bot found potential problems

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java Fixed Show fixed Hide fixed


          Corrected inefficient regex p4

a6634cd


          Updated changelog

Jeffery-Wasty previously approved these changes

View reviewed changes

barryw-mssql previously approved these changes

View reviewed changes

lilgreenbird reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java Show resolved Hide resolved

lilgreenbird previously approved these changes

View reviewed changes


          Added comment

c252a8b

tkyc dismissed stale reviews from lilgreenbird, barryw-mssql, and Jeffery-Wasty via

c252a8b

July 23, 2024 17:22

Jeffery-Wasty approved these changes

View reviewed changes

lilgreenbird approved these changes

View reviewed changes

barryw-mssql approved these changes

View reviewed changes

tkyc merged commit 0e97689 into main

19 checks passed

tkyc deleted the call-escape-syntax-fix branch

July 23, 2024 19:00

Eng-Fouad mentioned this pull request

Bump Microsoft SQL Server JDBC driver to 12.8.0 quarkusio/quarkus#42261

Merged

Jeffery-Wasty added this to the 12.8.0 milestone

Jeffery-Wasty added a commit that referenced this pull request


          Revert "Fixed regression with specifying arg names in call syntax (#2480

)"

This reverts commit 0e97689.

tkyc mentioned this pull request

Revert Execute Stored Procedure directly feature #2488

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet